chore: Update defaults to use legacy p2p #171
Conversation
evan-forbes
changed the title
Codecov Report
@@ Coverage Diff @@
## release/v0.46.x-celestia #171 +/- ##
=========================================================
Coverage 65.13% 65.13%
=========================================================
Files 682 682
Lines 71680 71687 +7
=========================================================
+ Hits 46688 46695 +7
Misses 22303 22303
Partials 2689 2689
|
| config.P2P.MaxNumInboundPeers = 250 | ||
| config.P2P.MaxNumOutboundPeers = 70 | ||
| config.P2P.MaxConnections = 320 |
There was a problem hiding this comment.
Do these still reflect the latest thinking? I thought most validators decreased these values again. TBH, I am not sure we should hard-code these settings without very clear evidence that this is actually stabilizing the network.
There was a problem hiding this comment.
I agree. Also as suggested earlier and in #151, we should move this to the app and core
|
I'm not sure, as per #151, we should probably move these default settings the app or to core. However, if we move them to core, then that causes other issues as many tests in tendermint rely on the current default values, and if we move them to the app then that will require decently sized refactor/copy paste of code. |
|
regardless, this needs to be updated to reflect the settings that we want, but I'm not sure that we have decided on what those are. converting to a draft for now |
|
closing as this is no longer an option and hasn't been for a while |
Description
This PR changes the default configs to use the legacy p2p stack, along with adding default seed nodes.
I've tested this manually, but would appreciate if someone else does as well. After replacing the cosmos sdk with this branches latest commit in celestia-app, all we have to do to start a full node is
Closes: #XXXX